From 2ed1e08707cd1eac279cd88b505a14c76ce9b537 Mon Sep 17 00:00:00 2001
From: naiba <hi@nai.ba>
Date: Mon, 18 Apr 2022 20:45:07 +0800
Subject: [PATCH] fix code scan alerts

---
 .github/workflows/test.yml              | 1 +
 cmd/dashboard/controller/common_page.go | 4 ++--
 resource/template/dashboard/login.html  | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index e7ca1b2..fe05549 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -6,6 +6,7 @@ on:
       - master
     paths-ignore:
       - ".github/workflows/agent.yml"
+      - ".github/workflows/codeql-analysis.yml"
       - ".github/workflows/test-on-pr.yml"
       - "README.md"
       - ".goreleaser.yml"
diff --git a/cmd/dashboard/controller/common_page.go b/cmd/dashboard/controller/common_page.go
index ca28ffe..9ee6119 100644
--- a/cmd/dashboard/controller/common_page.go
+++ b/cmd/dashboard/controller/common_page.go
@@ -322,8 +322,8 @@ func (cp *commonPage) terminal(c *gin.Context) {
 	}
 	defer conn.Close()
 
-	log.Println("NEZHA>> terminal connected", isAgent, c.Request.URL)
-	defer log.Println("NEZHA>> terminal disconnected", isAgent, c.Request.URL)
+	log.Printf("NEZHA>> terminal connected %t %q", isAgent, c.Request.URL)
+	defer log.Printf("NEZHA>> terminal disconnected %t %q", isAgent, c.Request.URL)
 
 	if isAgent {
 		terminal.agentConn = conn
diff --git a/resource/template/dashboard/login.html b/resource/template/dashboard/login.html
index 4a27ef4..dfe5c79 100644
--- a/resource/template/dashboard/login.html
+++ b/resource/template/dashboard/login.html
@@ -11,7 +11,7 @@
             </h2>
             <a href="/oauth2/login" class="ui fluid large nezha-primary-btn submit button">登录</a>
             <div class="ui message">
-                没有账号？ <a href="{{.RegistrationLink}}" target="_blank">注册</a>
+                没有账号？ <a href="{{.RegistrationLink}}" target="_blank" rel="noopener noreferrer">注册</a>
             </div>
         </div>
     </div>